fix(testing): stop code execution in describe.ignore
#6237
Merged
+75
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, code inside a
describe
block is executed in every case, even whendescribe.ignore
ordescribe.skip
is used. This behavior is reflected in the following example and is currently tested as expected behavior:Code:
Error:
Uncaught error from ./main.ts FAILED ERRORS ./main.ts (uncaught error) error: (in promise) AssertionError throw new AssertionError(msg); ^
This happens because the describe block is treated as a list of steps rather than as a single step itself. In my implementation, all code inside a describe.ignore block is ignored.
Fixes #6233