Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(async): fix flakiness of throttle example #6156

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Oct 29, 2024

closes #6144

@github-actions github-actions bot added the async label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.52%. Comparing base (ff6037a) to head (4939ca7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6156   +/-   ##
=======================================
  Coverage   96.51%   96.52%           
=======================================
  Files         536      536           
  Lines       40765    40765           
  Branches     6118     6118           
=======================================
+ Hits        39346    39347    +1     
+ Misses       1375     1374    -1     
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k force-pushed the try-fix-flakiness-of-throttle-example branch from 305fc72 to ab5e67e Compare October 29, 2024 07:16
@kt3k kt3k requested a review from bartlomieju October 29, 2024 10:45
@kt3k
Copy link
Member Author

kt3k commented Oct 29, 2024

Now it looks non-flaky

@kt3k kt3k merged commit 24cd7cf into denoland:main Oct 29, 2024
20 checks passed
@kt3k kt3k deleted the try-fix-flakiness-of-throttle-example branch October 29, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The example at async/unstable_throttle.ts$38-57.ts is flaky
2 participants