feat(collections/unstable): support Iterable argument in slidingWindows
#6095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liam-Tait
changed the title
Iterable argument in slidingWindows
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6095 +/- ##
==========================================
- Coverage 96.75% 96.57% -0.19%
==========================================
Files 509 535 +26
Lines 39175 40583 +1408
Branches 5795 6095 +300
==========================================
+ Hits 37905 39193 +1288
- Misses 1228 1346 +118
- Partials 42 44 +2 ☔ View full report in Codecov by Sentry. |
Liam-Tait
force-pushed
the
liam/sliding-windows-iterable
branch
from
1ef1dad
to
db5c445
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Iterable for
slidingWindowsWhile working here I have made the errors a bit more granular.
With light benchmarking I have also made the array use case around ~2x faster (on my machine).
#5470