-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement readString #607
Implement readString #607
Conversation
Hmm I am also thinking if we should also provide a version that possibly allow multi-char delimiter? |
IMO we need multichar delimiter |
On second thought I noticed that since BufReader is implemented in a way strictly compliant with Go’s bufio counterparts, maybe single char restriction is fine here. I do hope though if we can provide another utility for unlimited buffered reader that automatically resize/reallocate the internal buffer which would allow implementation of multi-char delim easier (maybe an extension of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #606