Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation(io/unstable): deprecate readRange() #6010

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 18, 2024

Towards #5989

@iuioiua iuioiua requested a review from kt3k as a code owner September 18, 2024 07:35
@iuioiua iuioiua enabled auto-merge (squash) September 18, 2024 07:35
@github-actions github-actions bot added the io label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (e1c8d24) to head (e946524).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6010      +/-   ##
==========================================
- Coverage   96.29%   96.28%   -0.01%     
==========================================
  Files         493      493              
  Lines       39533    39533              
  Branches     5837     5837              
==========================================
- Hits        38068    38065       -3     
- Misses       1423     1426       +3     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 3290659 into main Sep 18, 2024
16 checks passed
@iuioiua iuioiua deleted the deprecate-readRange branch September 18, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants