Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(io/unstable): remove sliceLongToBytes() #6005

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 17, 2024

What's changed

sliceLongToBytes() is being removed from @std/io.

Motivation

This function doesn't have a sufficient number of use cases to justify having it as part of the Standard Library.

Related

Towards #5989

@github-actions github-actions bot added the io label Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (3b51807) to head (c587a3f).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6005      +/-   ##
==========================================
- Coverage   96.29%   96.28%   -0.01%     
==========================================
  Files         493      492       -1     
  Lines       39528    39514      -14     
  Branches     5833     5832       -1     
==========================================
- Hits        38063    38046      -17     
- Misses       1423     1426       +3     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua closed this Sep 18, 2024
@iuioiua iuioiua reopened this Sep 25, 2024
@iuioiua iuioiua marked this pull request as ready for review September 25, 2024 02:12
@iuioiua iuioiua requested a review from kt3k as a code owner September 25, 2024 02:12
@iuioiua iuioiua enabled auto-merge (squash) September 25, 2024 02:19
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit eb064eb into main Sep 25, 2024
15 checks passed
@iuioiua iuioiua deleted the remove-sliceLongToBytes branch September 25, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants