Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(archive,log,testing): correct typos #5995

Merged
merged 3 commits into from
Sep 16, 2024
Merged

docs(archive,log,testing): correct typos #5995

merged 3 commits into from
Sep 16, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Sep 16, 2024

  • Use the American spelling of colors in docs for consistency with module and option names
  • Replace a few incorrect usages of it's

@canac
docs(log,testing): replace colours with colors
27e483c 
Use the American spelling of colors in docs for consistency with module
and option names.
@canac
docs(archive,testing): replace it's with its
c8ced70
@canac canac requested a review from kt3k as a code owner September 16, 2024 18:05
iuioiua
iuioiua approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you

@iuioiua iuioiua changed the title docs(archive,log,testing): colours --> colors and it's --> its docs(archive,log,testing): correct typos Sep 16, 2024
@iuioiua iuioiua enabled auto-merge (squash) September 16, 2024 22:46
@codecov Codecov
Copy link

codecov bot commented Sep 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (05b6d7e) to head (475bf11).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5995   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files         493      493           
  Lines       39530    39530           
  Branches     5833     5833           
=======================================
  Hits        38065    38065           
  Misses       1423     1423           
  Partials       42       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua merged commit 381d70d into denoland:main Sep 16, 2024
17 checks passed
@canac canac deleted the colours branch September 16, 2024 22:56
@canac
Copy link
Contributor Author

canac commented Sep 16, 2024

@iuioiua Thanks for the assist with that failing test!

@iuioiua
Copy link
Contributor

iuioiua commented Sep 16, 2024

No problem 👍🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
archive log testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @iuioiua