Fix "deno test" on windows

[lucacasonato]

Fixes #593

Use backslashes on windows for the default matcher globs.

Some tests don't run correctly on windows because they expect \n to result in a line break or / to be the file separator. These should probably be fixed in different PRs to keep this one simple.

[bartlomieju]

It seems that the file matching is working fine after all (example build). Maybe let's put off this change until we land updated test runner. Tests will fail if there are no matching files found.

[lucacasonato]

@bartlomieju The test succeedes, but it doesn't actually test anything. The tests itself aren't actually run. Look at the windows part of that link you sent. It finishes after just under 2 minutes while both Linux and MacOS take significantly longer. If you look at where 'deno test' is actually we excuted you will see that it does not find any tests to run. That means the tests on windows are broken. This is caused by the globs that are designed for Unix not working for windows because it uses a different path delimiter. I think this should go in as it fixes the issue.

[lucacasonato]

It seems that the file matching is working fine after all (example build). Maybe let's put off this change until we land updated test runner. Tests will fail if there are no matching files found.

Oh and tests do not fail if no files are found.

[bartlomieju]

@bartlomieju The test succeedes, but it doesn't actually test anything. The tests itself aren't actually run. Look at the windows part of that link you sent. It finishes after just under 2 minutes while both Linux and MacOS take significantly longer. If you look at where 'deno test' is actually we excuted you will see that it does not find any tests to run. That means the tests on windows are broken. This is caused by the globs that are designed for Unix not working for windows because it uses a different path delimiter. I think this should go in as it fixes the issue.

Ha! I could swear that I had different result when I pasted the link, dunno... Then the issue stands.

Oh and tests do not fail if no files are found.

Yes, they don't right now, I forgot to tag the PR which will introduce this behavior: #604

[nayeemrmn]

@lucacasonato You'll have to fix the issues to get this green.

For getMatchingUrlsLocal() just use join() instead of / like you've done here.

For xevalCliReplvar() replace \n with EOL from //fs/path/constants.ts.

[nayeemrmn]

@lucacasonato On second thoughts, I've just applied these fixes in #604 (b3926f0).

It would probably be easier to close this 🙏

[lucacasonato]

No Problem