Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(encoding/unstable): move base64url-stream module to unstable-base64url-stream #5959

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 12, 2024

Towards #5920

@iuioiua iuioiua requested a review from kt3k as a code owner September 12, 2024 05:45
@iuioiua iuioiua enabled auto-merge (squash) September 12, 2024 05:45
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (04ad602) to head (56f2426).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5959      +/-   ##
==========================================
- Coverage   96.32%   96.31%   -0.01%     
==========================================
  Files         488      488              
  Lines       39449    39449              
  Branches     5835     5835              
==========================================
- Hits        38000    37997       -3     
- Misses       1407     1410       +3     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment

encoding/unstable_base64url_stream.ts Outdated Show resolved Hide resolved
@iuioiua iuioiua requested a review from kt3k September 12, 2024 06:27
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 9ff5daf into main Sep 12, 2024
16 checks passed
@iuioiua iuioiua deleted the unstable-base64url-stream-move branch September 12, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants