-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING(path/unstable): move unstable overload of basename
to unstable-basename
#5957
BREAKING(path/unstable): move unstable overload of basename
to unstable-basename
#5957
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5957 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 484 486 +2
Lines 39403 39425 +22
Branches 5837 5836 -1
=======================================
+ Hits 37953 37976 +23
+ Misses 1408 1407 -1
Partials 42 42 ☔ View full report in Codecov by Sentry. |
path/basename.ts
Outdated
* | ||
* @param path Path to extract the name from. | ||
* @param suffix Suffix to remove from extracted name. | ||
* | ||
* @returns The basename of the path. | ||
*/ | ||
export function basename(path: string | URL, suffix?: string): string; | ||
export function basename(path: string | URL, suffix = ""): string { | ||
export function basename(path: string, suffix?: string): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export function basename(path: string, suffix?: string): string { | |
export function basename(path: string, suffix = ""): string { |
path/posix/basename.ts
Outdated
export function basename(path: string, suffix?: string): string { | ||
assertArgs(path, suffix ?? ""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto for the other functions
export function basename(path: string, suffix?: string): string { | |
assertArgs(path, suffix ?? ""); | |
export function basename(path: string, suffix = ""): string { | |
assertArgs(path, suffix); |
part of #5920
This PR moves the unstable overload of
basename
tounstable-basename