Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(net/unstable): move get-network-address module to unstable-get-network-address #5949

Merged
merged 3 commits into from
Sep 12, 2024
Merged

BREAKING(net/unstable): move get-network-address module to unstable-get-network-address #5949

merged 3 commits into from
Sep 12, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 12, 2024

Towards #5920

@iuioiua iuioiua requested a review from kt3k as a code owner September 12, 2024 03:54
@iuioiua iuioiua enabled auto-merge (squash) September 12, 2024 03:54
@codecov Codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (43657d8) to head (7d1e3c6).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5949      +/-   ##
==========================================
- Coverage   96.32%   96.32%   -0.01%     
==========================================
  Files         483      483              
  Lines       39403    39403              
  Branches     5839     5839              
==========================================
- Hits        37956    37953       -3     
- Misses       1405     1408       +3     
  Partials       42       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kt3k
kt3k reviewed Sep 12, 2024
View reviewed changes
http/file_server.ts Outdated Show resolved Hide resolved
@iuioiua iuioiua requested a review from kt3k September 12, 2024 04:02
kt3k
kt3k approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit b900e72 into main Sep 12, 2024
16 checks passed
@iuioiua iuioiua deleted the unstable-net-move branch September 12, 2024 04:05
@kt3k kt3k mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
http net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k