Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(http/unstable): move route module to unstable-route #5939

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 11, 2024

part of #5920

This PR moves route to ./unstable-route.

We usually do not re-export unstable APIs from mod.ts, but in this case I suggest we should keep it (at least for a while) as it's used in deno init --serve output.

@github-actions github-actions bot added the http label Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (8d7e184) to head (47b91ae).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5939      +/-   ##
==========================================
- Coverage   96.32%   96.32%   -0.01%     
==========================================
  Files         483      483              
  Lines       39403    39403              
  Branches     5838     5838              
==========================================
- Hits        37956    37953       -3     
- Misses       1405     1408       +3     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua
Copy link
Contributor

iuioiua commented Sep 12, 2024

Shouldn't this be marked as "BREAKING(http/unstable)"?

@kt3k kt3k changed the title refactor(http): move route to ./unstable-route BREAKING(http/unstable): move route to ./unstable-route Sep 12, 2024
@kt3k
Copy link
Member Author

kt3k commented Sep 12, 2024

Ok. Let's use BREAKING(pkg/unstable) pattern

Note: Deno CLI seems using the same pattern for breaking changes in unstables https://github.com/denoland/deno/blob/main/Releases.md#1460--20240822

@kt3k kt3k merged commit c594a0c into denoland:main Sep 12, 2024
17 checks passed
@kt3k kt3k deleted the refactor-http-move-unstable-route branch September 12, 2024 03:50
@iuioiua iuioiua changed the title BREAKING(http/unstable): move route to ./unstable-route BREAKING(http/unstable): move route module to unstable-route Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants