Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(url): remove @std/url #5931

Merged
merged 1 commit into from
Sep 10, 2024
Merged

BREAKING(url): remove @std/url #5931

merged 1 commit into from
Sep 10, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 10, 2024

What's changed

This change removes the @std/url package.

Motivation

See #5530 for background.

Migration

Use @std/path APIs instead. See the documentation for the following symbols for usage instructions:

@iuioiua iuioiua requested a review from kt3k as a code owner September 10, 2024 08:16
@iuioiua iuioiua enabled auto-merge (squash) September 10, 2024 08:16
@github-actions github-actions bot added the url label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (9c36e5e) to head (67bf134).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5931      +/-   ##
==========================================
- Coverage   96.25%   96.24%   -0.01%     
==========================================
  Files         489      482       -7     
  Lines       39459    39388      -71     
  Branches     5824     5824              
==========================================
- Hits        37980    37909      -71     
  Misses       1435     1435              
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit fc0f55c into main Sep 10, 2024
17 checks passed
@iuioiua iuioiua deleted the remove-url-2 branch September 10, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants