Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump prettier to 1.18.2 #592

Merged
merged 4 commits into from
Sep 12, 2019
Merged

bump prettier to 1.18.2 #592

merged 4 commits into from
Sep 12, 2019

Conversation

axetroy
Copy link
Contributor

@axetroy axetroy commented Sep 11, 2019

refs: #591

@bartlomieju
Copy link
Member

Should there be so many changes after the upgrade of prettier? I'd expect not to reformat any files... 🤔

@axetroy
Copy link
Contributor Author

axetroy commented Sep 11, 2019

@bartlomieju
Prettier does need to reformat the file after the upgrade.

But this upgrade got a strange thing, I can run the test locally, but it does not pass in CI.

prettier/vendor/standalone.js Outdated Show resolved Hide resolved
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 06958a4 into denoland:master Sep 12, 2019
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
Work in progress. See denoland#591 for the relevant discussion.

---------

Co-authored-by: Asher Gomez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants