Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): show hostname as 'localhost' for 0.0.0.0 on windows #5918

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 5, 2024

This PR shows hostname as localhost on windows when the server listens at 0.0.0.0.

This substitution of the hostname used to be done by CLI, but we stopped doing that when onListen handler is set in denoland/deno#24777

@github-actions github-actions bot added the http label Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.25%. Comparing base (149839b) to head (33c10af).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
http/file_server.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5918   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files         491      491           
  Lines       39440    39443    +3     
  Branches     5811     5811           
=======================================
+ Hits        37961    37964    +3     
  Misses       1435     1435           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k merged commit fb79076 into denoland:main Sep 5, 2024
16 checks passed
@kt3k kt3k deleted the fix-http-file-server-windows branch September 5, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants