fix(expect): support expect.hasAssertions()

[eryue0220]

This pr is one of part to solve #3964, which is to support expect.hasAssertion api.

[codecov]

Codecov Report

Attention: Patch coverage is 89.06250% with 7 lines in your changes missing coverage. Please review.

Project coverage is 96.30%. Comparing base (1d22380) to head (1d55626).
Report is 61 commits behind head on main.

Files with missing lines	Patch %	Lines
testing/bdd.ts	42.85%	4 Missing ⚠️
expect/_assertion.ts	66.66%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5901      +/-   ##
==========================================
- Coverage   96.31%   96.30%   -0.01%     
==========================================
  Files         482      495      +13     
  Lines       39388    39571     +183     
  Branches     5824     5839      +15     
==========================================
+ Hits        37935    38108     +173     
- Misses       1411     1421      +10     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[iuioiua]

This file doesn't seem needed. We should just simply throw AssertionError in testing/bdd.ts.

[eryue0220]

Updated.

[kt3k]

Suggested change

	export function hasAssertion() {
	export function hasAssertions() {

[eryue0220]

Updated.

[kt3k]

This seems only works for the first use of hasAssertions as we don't create a new assertionState for each it call.

The below script doesn't throw with the 2nd case, which misses assertions:

import { expect } from "@std/expect";
import { test } from "@std/testing/bdd";

test("1", () => {
  expect.hasAssertions();
  expect(1).toBe(1);
});
test("2", () => {
  expect.hasAssertions();
});

[eryue0220]

This seems only works for the first use of hasAssertions as we don't create a new assertionState for each it call.

The below script doesn't throw with the 2nd case, which misses assertions:

import { expect } from "@std/expect";
import { test } from "@std/testing/bdd";

test("1", () => {
  expect.hasAssertions();
  expect(1).toBe(1);
});
test("2", () => {
  expect.hasAssertions();
});

Yes, the above code had some bugs. and I've updated.

Thanks.

[kt3k]

I feel this check is unnecessary. If I removed this check, the test cases still pass.

I'm removing this block.

[eryue0220]

There is a little tricky about this, I think you run the test inside Deno.test and then it will never throw error. But if you remove it, then it works.

[kt3k]

This API has been documented as 'still not available'. I think we can consider this addition as 'fix' as this is already expected to be added.

[kt3k]

LGTM. Thanks for updating!