Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yaml): handle String instances #5897

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

timreichen
Copy link
Contributor

Ref: #5857

Note
It seems weird to handle special treat strings in stringifyNode(). Maybe there is a way to move the evaluation inside Type.predicate like other types in a future PR.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (890958c) to head (4a860d6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5897   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files         483      483           
  Lines       39063    39064    +1     
  Branches     5730     5731    +1     
=======================================
+ Hits        37629    37630    +1     
  Misses       1390     1390           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@iuioiua iuioiua merged commit 6c684b8 into denoland:main Sep 3, 2024
16 checks passed
@iuioiua iuioiua changed the title fix(yaml): handle string instances fix(yaml): handle String instances Sep 3, 2024
@timreichen timreichen deleted the yaml-fix-string branch September 4, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants