Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): cleanup utility functions #5886

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

timreichen
Copy link
Contributor

Changes
This PR removes makes isPlainSafeFirst() call isPlainSafe() and removes double checks.
It also removes unhelpful comments and adds jsdoc comments to the functions.

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (f86e911) to head (c9b213b).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5886      +/-   ##
==========================================
- Coverage   96.34%   96.33%   -0.01%     
==========================================
  Files         479      479              
  Lines       38674    38656      -18     
  Branches     5631     5623       -8     
==========================================
- Hits        37260    37241      -19     
- Misses       1370     1371       +1     
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@iuioiua iuioiua merged commit 8abff45 into denoland:main Sep 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants