Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(yaml): add regexp type tests #5862

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

timreichen
Copy link
Contributor

No description provided.

@timreichen timreichen requested a review from kt3k as a code owner August 29, 2024 07:34
@github-actions github-actions bot added the yaml label Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (0a71a4d) to head (6415bee).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5862      +/-   ##
==========================================
+ Coverage   96.26%   96.32%   +0.06%     
==========================================
  Files         479      479              
  Lines       38705    38705              
  Branches     5617     5626       +9     
==========================================
+ Hits        37258    37282      +24     
+ Misses       1404     1380      -24     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua
Copy link
Contributor

iuioiua commented Aug 29, 2024

This doesn't seem to increase test coverage for the code changed in #5860

@timreichen
Copy link
Contributor Author

This doesn't seem to increase test coverage for the code changed in #5860

Sorry, I uploaded the wrong branch. Should be fixed now.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you'd also be able to cover this line?

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'll merge as-is. Thank you!

@iuioiua iuioiua merged commit 0b59bfd into denoland:main Aug 29, 2024
16 checks passed
@timreichen timreichen deleted the yaml-add-regexp-tests branch August 29, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants