refactor(assert,datetime,fmt,io,streams): consistently `throw new Error()` instead of `throw Error()` #5855

irbull · 2024-08-28T15:16:34Z

…nstead of throw

To ensure consistency across the codebase, this commit refactors the codebase to use throw new Error instead of throw for throwing errors.

#5854

…nstead of `throw` To ensure consistency across the codebase, this commit refactors the codebase to use `throw new Error` instead of `throw` for throwing errors. denoland#5854

codecov · 2024-08-28T15:18:10Z

Codecov Report

Attention: Patch coverage is 24.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 96.26%. Comparing base (a55ee9c) to head (4a33452).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
datetime/_date_time_formatter.ts	17.64%	14 Missing ⚠️
io/buf_reader.ts	0.00%	2 Missing ⚠️
io/buffer.ts	0.00%	2 Missing ⚠️
fmt/printf.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5855   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         479      479           
  Lines       38738    38738           
  Branches     5618     5618           
=======================================
  Hits        37292    37292           
  Misses       1403     1403           
  Partials       43       43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iuioiua

Great! Thank you.

iuioiua · 2024-08-28T22:56:46Z

Does this close #5854?

refactor(assert, datetime, fmt, io, streams): use throw new Error i…

4a33452

…nstead of `throw` To ensure consistency across the codebase, this commit refactors the codebase to use `throw new Error` instead of `throw` for throwing errors. denoland#5854

irbull requested review from kt3k and crowlKats as code owners August 28, 2024 15:16

github-actions bot added fmt streams datetime io assert labels Aug 28, 2024

iuioiua changed the title ~~refactor(assert, datetime, fmt, io, streams): use throw new Error i…~~ refactor(assert,datetime,fmt,io,streams): consistently throw new Error() instead of throw Error() Aug 28, 2024

iuioiua approved these changes Aug 28, 2024

View reviewed changes

iuioiua merged commit 3b3a761 into denoland:main Aug 28, 2024
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(assert,datetime,fmt,io,streams): consistently `throw new Error()` instead of `throw Error()` #5855

refactor(assert,datetime,fmt,io,streams): consistently `throw new Error()` instead of `throw Error()` #5855

irbull commented Aug 28, 2024

codecov bot commented Aug 28, 2024 •

edited

Loading

iuioiua left a comment

iuioiua commented Aug 28, 2024

refactor(assert,datetime,fmt,io,streams): consistently throw new Error() instead of throw Error() #5855

refactor(assert,datetime,fmt,io,streams): consistently throw new Error() instead of throw Error() #5855

Conversation

irbull commented Aug 28, 2024

codecov bot commented Aug 28, 2024 • edited Loading

Codecov Report

iuioiua left a comment

Choose a reason for hiding this comment

iuioiua commented Aug 28, 2024

refactor(assert,datetime,fmt,io,streams): consistently `throw new Error()` instead of `throw Error()` #5855

refactor(assert,datetime,fmt,io,streams): consistently `throw new Error()` instead of `throw Error()` #5855

codecov bot commented Aug 28, 2024 •

edited

Loading