Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): inline readTagProperty() #5849

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

timreichen
Copy link
Contributor

Ref: #5749

@timreichen timreichen requested a review from kt3k as a code owner August 28, 2024 06:21
@github-actions github-actions bot added the yaml label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 34.17722% with 52 lines in your changes missing coverage. Please review.

Project coverage is 96.24%. Comparing base (2e209c0) to head (f2575a1).
Report is 1 commits behind head on main.

Files Patch % Lines
yaml/_loader_state.ts 34.17% 50 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5849      +/-   ##
==========================================
- Coverage   96.26%   96.24%   -0.02%     
==========================================
  Files         479      479              
  Lines       38751    38751              
  Branches     5620     5620              
==========================================
- Hits        37302    37296       -6     
- Misses       1406     1412       +6     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@iuioiua iuioiua merged commit 937da39 into denoland:main Aug 28, 2024
16 checks passed
@timreichen timreichen deleted the yaml-inline-readTagProperty branch August 28, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants