Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(yaml): add undefined object entry with skipInvalid and flowLevel option test #5829

Conversation

timreichen
Copy link
Contributor

No description provided.

@timreichen timreichen requested a review from kt3k as a code owner August 26, 2024 09:33
@github-actions github-actions bot added the yaml label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (0ebec10) to head (7ad0f0f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5829      +/-   ##
==========================================
+ Coverage   96.26%   96.27%   +0.01%     
==========================================
  Files         479      479              
  Lines       38746    38746              
  Branches     5620     5621       +1     
==========================================
+ Hits        37299    37304       +5     
+ Misses       1405     1399       -6     
- Partials       42       43       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this reduces 8 missed lines in the coverage report of _dumper_state.ts

LGTM

@kt3k kt3k merged commit 3946983 into denoland:main Aug 26, 2024
16 checks passed
@timreichen timreichen deleted the yaml-add-undefined-object-entry-with-skipInvalid-and-flowLevel-option-test branch August 26, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants