refactor(csv): remove dead code and improve tests #5151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5151 +/- ##
=======================================
Coverage 93.20% 93.21%
=======================================
Files 473 473
Lines 38060 38054 -6
Branches 5420 5421 +1
=======================================
- Hits 35473 35471 -2
+ Misses 2543 2539 -4
Partials 44 44 ☔ View full report in Codecov by Sentry. |
kt3k
commented
Jun 26, 2024
Comment on lines
-54
to
-55
| !this.#input.startsWith("\r\n", this.#cursor) || | ||
| !this.#input.startsWith("\n", this.#cursor) |
There was a problem hiding this comment.
This condition can't be false as the same string can't start with both \r\n and \n.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #3713
This improves the test coverage of
csv/parse.ts.