Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli): reduce flakiness of spinner test #4738

Merged
merged 2 commits into from
May 15, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 15, 2024

Updates spinner test. Now the test case waits longer time (350ms) to make sure green text appearing

closes #4734

@github-actions github-actions bot added the cli label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (f2c05b7) to head (2161502).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4738      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         483      484       +1     
  Lines       41297    41296       -1     
  Branches     5318     5318              
==========================================
- Hits        37945    37942       -3     
- Misses       3295     3297       +2     
  Partials       57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k merged commit d3729aa into denoland:main May 15, 2024
12 checks passed
@kt3k kt3k deleted the fix-flaky-spinner-test branch May 30, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: flaky Spinner.color test
2 participants