Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(internal): cleanups and documentation improvements #4706

Merged
merged 9 commits into from
May 15, 2024
Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 10, 2024

These documentation additions are made to improve the maintainability of this package, as it's only used internally.

Towards #4739

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (f2c05b7) to head (1b0741f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4706      +/-   ##
==========================================
- Coverage   91.88%   91.88%   -0.01%     
==========================================
  Files         483      484       +1     
  Lines       41297    41296       -1     
  Branches     5318     5318              
==========================================
- Hits        37945    37944       -1     
  Misses       3295     3295              
  Partials       57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua marked this pull request as ready for review May 13, 2024 04:32
@iuioiua iuioiua requested a review from kt3k as a code owner May 13, 2024 04:32
@iuioiua iuioiua changed the title feat(internal): [email protected] docs(internal): cleanups and documentation improvements May 15, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iuioiua iuioiua enabled auto-merge (squash) May 15, 2024 07:46
@iuioiua iuioiua merged commit 17d7fff into main May 15, 2024
12 checks passed
@iuioiua iuioiua deleted the internal-1 branch May 15, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants