Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(internal): cleanup _internals #4702

Merged
merged 1 commit into from
May 9, 2024
Merged

refactor(internal): cleanup _internals #4702

merged 1 commit into from
May 9, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 9, 2024

This is no longer needed, thanks to #4700 and #4701.

Related #4699

@iuioiua iuioiua requested a review from kt3k as a code owner May 9, 2024 06:43
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (668c99a) to head (5dae230).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4702      +/-   ##
==========================================
- Coverage   91.49%   91.49%   -0.01%     
==========================================
  Files         477      477              
  Lines       37277    37276       -1     
  Branches     5314     5314              
==========================================
- Hits        34106    34105       -1     
  Misses       3115     3115              
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 54f93b8 into main May 9, 2024
13 checks passed
@iuioiua iuioiua deleted the clean-4699 branch May 9, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants