Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(collections): [email protected] #4697

Merged
merged 4 commits into from
May 20, 2024
Merged

chore(collections): [email protected] #4697

merged 4 commits into from
May 20, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 8, 2024

Prerequisite #4696

Towards #4647

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (c9167d6) to head (d1331f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4697   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         485      485           
  Lines       41314    41314           
  Branches     5319     5319           
=======================================
  Hits        37965    37965           
  Misses       3292     3292           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua marked this pull request as ready for review May 9, 2024 03:46
@iuioiua iuioiua requested a review from kt3k as a code owner May 9, 2024 03:46
@iuioiua iuioiua enabled auto-merge (squash) May 9, 2024 10:36
@kt3k kt3k changed the title feat(collections): [email protected] chore(collections): [email protected] May 17, 2024
@kt3k
Copy link
Member

kt3k commented May 20, 2024

Note: The designs of APIs are discussed in the issues/PRs linked from this umbrella issue #1065

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 2c88408 into main May 20, 2024
12 checks passed
@iuioiua iuioiua deleted the collections-rc-1 branch May 20, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants