Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bytes,collections): fix doc checker and documentation #4691

Merged
merged 2 commits into from
May 8, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 8, 2024

I previously added a modification that ensured function overload signatures were checked instead of implementation signatures, but this also prevented functions without overloads from being skipped. This PR fixes that and applies documentation fixes where spotted.

@iuioiua iuioiua requested a review from kt3k as a code owner May 8, 2024 01:36
@iuioiua iuioiua changed the title docs(bytes,collection): fix doc checker and documentation docs(bytes,collections): fix doc checker and documentation May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (14f9cc6) to head (1750c64).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4691   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files         477      477           
  Lines       37318    37318           
  Branches     5325     5325           
=======================================
  Hits        34137    34137           
  Misses       3125     3125           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@iuioiua iuioiua merged commit a079dd3 into main May 8, 2024
14 checks passed
@iuioiua iuioiua deleted the fix-doc-check branch May 8, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants