Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bytes): improve invalid count error message for repeat() #4603

Merged
merged 3 commits into from
Apr 17, 2024
Merged

fix(bytes): improve invalid count error message for repeat() #4603

merged 3 commits into from
Apr 17, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Apr 17, 2024

This change simplifies the error logic and message in repeat() when the count parameter is negative or not an integer.

@iuioiua iuioiua requested a review from kt3k as a code owner April 17, 2024 04:49
@github-actions github-actions bot added the bytes label Apr 17, 2024
kt3k
kt3k approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message looks better to me.

LGTM

@iuioiua iuioiua enabled auto-merge (squash) April 17, 2024 05:06
@iuioiua iuioiua merged commit cb2b74a into main Apr 17, 2024
12 checks passed
@iuioiua iuioiua deleted the repeat-count-error branch April 17, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
bytes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k