refactor(cli): cleanup parse_args.ts
#4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
suggested changes
Feb 1, 2024
Co-authored-by: Asher Gomez <[email protected]>
Co-authored-by: Asher Gomez <[email protected]>
|
A bit is going on here. Can you add your own comments (in GitHub, not in the code), where appropriate, to ease our understanding and reviews? |
timreichen
commented
Feb 3, 2024
iuioiua
suggested changes
Feb 7, 2024
kt3k
added a commit
to kt3k/deno_std
that referenced
this pull request
Mar 14, 2024
This reverts commit 8c022c4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes redundant code in
parse_args.tsand makes code more readable and possibly improves performance byMapSetThe code can still be made more readable. There probably will be more PRs in the future to do so.