Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(node): change Promise.All to Promise.all #2569

Merged
merged 1 commit into from
Aug 26, 2022
Merged

chore(node): change Promise.All to Promise.all #2569

merged 1 commit into from
Aug 26, 2022

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Aug 26, 2022 •
edited
Loading

I run grep 'Promise.All' -nr . in the repo and only found 3 typos. Let me know if I miss somewhere else.

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

kt3k
kt3k approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This means these lines are not tested in test cases...

@kt3k kt3k merged commit 63be402 into denoland:main Aug 26, 2022
@ydcjeff ydcjeff deleted the gh-2566 branch August 26, 2022 10:16
@cjihrig cjihrig mentioned this pull request Aug 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is Promise.All a typo or a thing?
3 participants
@ydcjeff @CLAassistant @kt3k