Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): prevent env permission prompt #2519

Closed
wants to merge 1 commit into from
Closed

feat(node): prevent env permission prompt #2519

wants to merge 1 commit into from

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Aug 13, 2022

This is for #2507.

@kt3k
Copy link
Member

kt3k commented Aug 13, 2022

Thanks for your contribution, but see this comment #2507 (comment) in the original issue. We can't use top-level-await in std/node to keep the loading of node/global.ts synchronous.

Closing without merge. Thanks for your efforts anyways.

@kt3k kt3k closed this Aug 13, 2022
@iuioiua iuioiua deleted the remove-permission-prompt-for-node branch August 15, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants