Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(encoding/csv): sync parse #2491

Merged
merged 3 commits into from
Aug 13, 2022
Merged

feat(encoding/csv): sync parse #2491

merged 3 commits into from
Aug 13, 2022

Conversation

timreichen
Copy link
Contributor

  • removes BufReader as input for parse
  • makes parse sync and browser compatible

@timreichen timreichen mentioned this pull request Aug 3, 2022
Closed
6 tasks
kt3k
kt3k approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice to have this module browser compatible.

Dropping of BufReader support makes sense to me as we're leaving from Reader/Writer interfaces for IO

@kt3k kt3k merged commit 33afdfe into denoland:main Aug 13, 2022
@timreichen timreichen deleted the csv_sync_parse branch August 14, 2022 13:40
@ayame113 ayame113 mentioned this pull request Aug 24, 2022
Closed
@kt3k kt3k mentioned this pull request Sep 7, 2022
Merged
This was referenced Dec 19, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timreichen @kt3k