feat(node/net): unix domain socket support

_deno_unstable.ts

@@ -2,6 +2,8 @@
 // @ts-nocheck Bypass static errors for missing --unstable.
 
 export type HttpClient = Deno.HttpClient;
+export type UnixConnectOptions = Deno.UnixConnectOptions;
+export type UnixListenOptions = Deno.UnixListenOptions;
 
 export function addSignalListener(
   ...args: Parameters<typeof Deno.addSignalListener>
@@ -153,6 +155,18 @@ export function networkInterfaces(
   }
 }
 
+export async function connect(
+  options: UnixConnectOptions,
+): Promise<Deno.UnixConn> {
+  return await Deno.connect(options);
+}
+
+export function listen(
+  options: UnixListenOptions & { transport: "unix" },
+): ReturnType<typeof Deno.listen> {
+  return Deno.listen(options);
+}
+
 export function ListenerRef(
   listener: Deno.Listener,
   ...args: Parameters<Deno.Listener["ref"]>

node/README.md

@@ -112,7 +112,7 @@ workflow.
 $ deno task node:setup
 ```
 
-You can aditionally pass the `-y`/`-n` flag to use test cache or generating
+You can additionally pass the `-y`/`-n` flag to use test cache or generating
 tests from scratch instead of being prompted at the moment of running it.
 
 ```zsh

node/_events.mjs

@@ -789,6 +789,7 @@ export function getEventListeners(emitterOrTarget, type) {
     return emitterOrTarget.listeners(type);
   }
   if (emitterOrTarget instanceof EventTarget) {
+    // TODO: kEvents is not defined
     const root = emitterOrTarget[kEvents].get(type);
     const listeners = [];
     let handler = root?.next;

node/_tools/common.ts

@@ -41,7 +41,7 @@ export const ignoreList = Object.entries(config.ignore).reduce(
 export function getPathsFromTestSuites(suites: TestSuites): string[] {
   const testPaths: string[] = [];
   for (const [dir, paths] of Object.entries(suites)) {
-    if (dir === "parallel" || dir === "internet") {
+    if (["parallel", "internet", "pummel"].includes(dir)) {
       for (const path of paths) {
         testPaths.push(join(dir, path));
       }

node/_tools/config.json

@@ -32,6 +32,16 @@
       "test-fs-rmdir-recursive.js",
       "test-fs-write-file.js",
       "test-fs-write.js",
+      "test-net-better-error-messages-path.js",
+      "test-net-connect-buffer.js",
+      "test-net-connect-buffer2.js",
+      "test-net-end-close.js",
+      "test-net-listen-invalid-port.js",
+      "test-net-server-call-listen-multiple-times.js",
+      "test-net-server-listen-path.js",
+      "test-net-server-try-ports.js",
+      "test-net-socket-timeout.js",
+      "test-net-write-arguments.js",
       "test-os.js",
       "test-path-resolve.js",
       "test-path.js",
@@ -56,6 +66,10 @@
       "test-zlib-write-after-flush.js",
       "test-zlib-zero-byte.js",
       "test-zlib-zero-windowBits.js"
+    ],
+    "pummel": [
+      "test-net-bytes-per-incoming-chunk-overhead.js",
+      "test-net-write-callbacks.js"
     ]
   },
   "tests": {
@@ -225,7 +239,85 @@
       "test-http-url.parse-path.js",
       "test-http-url.parse-post.js",
       "test-http-url.parse-search.js",
+      "test-net-access-byteswritten.js",
+      "test-net-after-close.js",
+      "test-net-allow-half-open.js",
+      "test-net-better-error-messages-listen-path.js",
+      "test-net-better-error-messages-listen.js",
+      "test-net-better-error-messages-path.js",
+      "test-net-better-error-messages-port-hostname.js",
+      "test-net-bind-twice.js",
+      "test-net-buffersize.js",
+      "test-net-bytes-written-large.js",
+      "test-net-can-reset-timeout.js",
+      "test-net-connect-after-destroy.js",
+      "test-net-connect-buffer.js",
+      "test-net-connect-buffer2.js",
+      "test-net-connect-call-socket-connect.js",
+      "test-net-connect-destroy.js",
+      "test-net-connect-immediate-destroy.js",
+      "test-net-connect-immediate-finish.js",
+      "test-net-connect-no-arg.js",
+      "test-net-connect-options-ipv6.js",
+      "test-net-connect-options-port.js",
+      "test-net-dns-custom-lookup.js",
+      "test-net-dns-error.js",
+      "test-net-dns-lookup-skip.js",
+      "test-net-dns-lookup.js",
+      "test-net-during-close.js",
+      "test-net-eaddrinuse.js",
+      "test-net-end-close.js",
+      "test-net-end-destroyed.js",
+      "test-net-end-without-connect.js",
+      "test-net-isip.js",
+      "test-net-isipv4.js",
+      "test-net-isipv6.js",
+      "test-net-listen-after-destroying-stdin.js",
+      "test-net-listen-close-server-callback-is-not-function.js",
+      "test-net-listen-close-server.js",
+      "test-net-listen-error.js",
+      "test-net-listen-invalid-port.js",
+      "test-net-listening.js",
+      "test-net-local-address-port.js",
+      "test-net-localerror.js",
+      "test-net-options-lookup.js",
+      "test-net-pause-resume-connecting.js",
+      "test-net-persistent-ref-unref.js",
+      "test-net-pipe-connect-errors.js",
+      "test-net-remote-address-port.js",
+      "test-net-server-call-listen-multiple-times.js",
+      "test-net-server-capture-rejection.js",
+      "test-net-server-close.js",
+      "test-net-server-listen-options-signal.js",
+      "test-net-server-listen-options.js",
+      "test-net-server-listen-path.js",
+      "test-net-server-listen-remove-callback.js",
+      "test-net-server-max-connections.js",
+      "test-net-server-options.js",
+      "test-net-server-pause-on-connect.js",
+      "test-net-server-try-ports.js",
       "test-net-server-unref-persistent.js",
+      "test-net-server-unref.js",
+      "test-net-socket-close-after-end.js",
+      "test-net-socket-connect-without-cb.js",
+      "test-net-socket-connecting.js",
+      "test-net-socket-destroy-send.js",
+      "test-net-socket-destroy-twice.js",
+      "test-net-socket-end-before-connect.js",
+      "test-net-socket-end-callback.js",
+      "test-net-socket-no-halfopen-enforcer.js",
+      "test-net-socket-ready-without-cb.js",
+      "test-net-socket-timeout.js",
+      "test-net-socket-write-after-close.js",
+      "test-net-socket-write-error.js",
+      "test-net-sync-cork.js",
+      "test-net-timeout-no-handle.js",
+      "test-net-writable.js",
+      "test-net-write-after-end-nt.js",
+      "test-net-write-arguments.js",
+      "test-net-write-fully-async-buffer.js",
+      "test-net-write-fully-async-hex-string.js",
+      "test-net-write-slow.js",
       "test-next-tick-doesnt-hang.js",
       "test-next-tick-fixed-queue-regression.js",
       "test-next-tick-intentional-starvation.js",
@@ -470,6 +562,11 @@
       "test-zlib-write-after-flush.js",
       "test-zlib-zero-byte.js",
       "test-zlib-zero-windowBits.js"
+    ],
+    "pummel": [
+      "test-net-bytes-per-incoming-chunk-overhead.js",
+      "test-net-pingpong-delay.js",
+      "test-net-write-callbacks.js"
     ]
   },
   "windowsIgnore": {
@@ -486,6 +583,10 @@
       "test-fs-write-file-sync.js",
       "test-fs-write-file.js",
       "test-http-client-reject-cr-no-lf.js",
+      "test-net-better-error-messages-listen-path.js",
+      "test-net-better-error-messages-path.js",
+      "test-net-pipe-connect-errors.js",
+      "test-net-server-listen-path.js",
       "test-util-inspect-getters-accessing-this.js",
       "test-util-inspect-long-running.js",
       "test-util-inspect.js"

node/_tools/setup.ts

@@ -27,7 +27,7 @@ import { downloadFile } from "../../_util/download_file.ts";
  *
  * Usage: `deno run --allow-read --allow-net --allow-write setup.ts`
  *
- * You can aditionally pass a flag to indicate if cache should be used for generating
+ * You can additionally pass a flag to indicate if cache should be used for generating
  * the tests, or to generate the tests from scratch (-y/-n)
  */
 

node/_tools/test/common/index.js

@@ -11,7 +11,9 @@
  */
 'use strict';
 const assert = require("assert");
+const path = require("path");
 const util = require("util");
+const tmpdir = require("./tmpdir");
 
 function platformTimeout(ms) {
   return ms;
@@ -345,6 +347,13 @@ function skip(msg) {
   process.exit(0);
 }
 
+const PIPE = (() => {
+  const localRelative = path.relative(process.cwd(), `${tmpdir.path}/`);
+  const pipePrefix = isWindows ? "\\\\.\\pipe\\" : localRelative;
+  const pipeName = `node-test.${process.pid}.sock`;
+  return path.join(pipePrefix, pipeName);
+})();
+
 function getArrayBufferViews(buf) {
   const { buffer, byteOffset, byteLength } = buf;
 
@@ -387,6 +396,7 @@ module.exports = {
   mustCallAtLeast,
   mustNotCall,
   mustSucceed,
+  PIPE,
   platformTimeout,
   printSkipMessage,
   skipIfDumbTerminal,

node/_tools/test/parallel/test-net-access-byteswritten.js

@@ -0,0 +1,28 @@
+// deno-fmt-ignore-file
+// deno-lint-ignore-file
+
+// Copyright Joyent and Node contributors. All rights reserved. MIT license.
+// Taken from Node 16.13.0
+// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually
+
+'use strict';
+
+const common = require('../common');
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+
+const assert = require('assert');
+const net = require('net');
+const tls = require('tls');
+const tty = require('tty');
+
+// Check that the bytesWritten getter doesn't crash if object isn't
+// constructed.
+assert.strictEqual(net.Socket.prototype.bytesWritten, undefined);
+assert.strictEqual(Object.getPrototypeOf(tls.TLSSocket).prototype.bytesWritten,
+                   undefined);
+assert.strictEqual(tls.TLSSocket.prototype.bytesWritten, undefined);
+assert.strictEqual(Object.getPrototypeOf(tty.ReadStream).prototype.bytesWritten,
+                   undefined);
+assert.strictEqual(tty.ReadStream.prototype.bytesWritten, undefined);
+assert.strictEqual(tty.WriteStream.prototype.bytesWritten, undefined);

node/_tools/test/parallel/test-net-after-close.js

@@ -0,0 +1,58 @@
+// deno-fmt-ignore-file
+// deno-lint-ignore-file
+
+// Copyright Joyent and Node contributors. All rights reserved. MIT license.
+// Taken from Node 16.13.0
+// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually
+
+// Copyright Joyent, Inc. and other Node contributors.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the
+// "Software"), to deal in the Software without restriction, including
+// without limitation the rights to use, copy, modify, merge, publish,
+// distribute, sublicense, and/or sell copies of the Software, and to permit
+// persons to whom the Software is furnished to do so, subject to the
+// following conditions:
+//
+// The above copyright notice and this permission notice shall be included
+// in all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+// USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const net = require('net');
+
+const server = net.createServer(common.mustCall((s) => {
+  console.error('SERVER: got connection');
+  s.end();
+}));
+
+server.listen(0, common.mustCall(() => {
+  const c = net.createConnection(server.address().port);
+  c.on('close', common.mustCall(() => {
+    /* eslint-disable no-unused-expressions */
+    console.error('connection closed');
+    assert.strictEqual(c._handle, null);
+    // Calling functions / accessing properties of a closed socket should not
+    // throw.
+    c.setNoDelay();
+    c.setKeepAlive();
+    c.bufferSize;
+    c.pause();
+    c.resume();
+    c.address();
+    c.remoteAddress;
+    c.remotePort;
+    server.close();
+    /* eslint-enable no-unused-expressions */
+  }));
+}));

node/_tools/test/parallel/test-net-allow-half-open.js

@@ -0,0 +1,54 @@
+// deno-fmt-ignore-file
+// deno-lint-ignore-file
+
+// Copyright Joyent and Node contributors. All rights reserved. MIT license.
+// Taken from Node 16.13.0
+// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually
+
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+const net = require('net');
+
+{
+  const server = net.createServer(common.mustCall((socket) => {
+    socket.end(Buffer.alloc(1024));
+  })).listen(0, common.mustCall(() => {
+    const socket = net.connect(server.address().port);
+    assert.strictEqual(socket.allowHalfOpen, false);
+    socket.resume();
+    socket.on('end', common.mustCall(() => {
+      process.nextTick(() => {
+        // Ensure socket is not destroyed straight away
+        // without proper shutdown.
+        assert(!socket.destroyed);
+        server.close();
+      });
+    }));
+    socket.on('finish', common.mustCall(() => {
+      assert(!socket.destroyed);
+    }));
+    socket.on('close', common.mustCall());
+  }));
+}
+
+{
+  const server = net.createServer(common.mustCall((socket) => {
+    socket.end(Buffer.alloc(1024));
+  })).listen(0, common.mustCall(() => {
+    const socket = net.connect(server.address().port);
+    assert.strictEqual(socket.allowHalfOpen, false);
+    socket.resume();
+    socket.on('end', common.mustCall(() => {
+      assert(!socket.destroyed);
+    }));
+    socket.end('asd');
+    socket.on('finish', common.mustCall(() => {
+      assert(!socket.destroyed);
+    }));
+    socket.on('close', common.mustCall(() => {
+      server.close();
+    }));
+  }));
+}

node/_tools/test/parallel/test-net-better-error-messages-listen-path.js

@@ -0,0 +1,17 @@
+// deno-fmt-ignore-file
+// deno-lint-ignore-file
+
+// Copyright Joyent and Node contributors. All rights reserved. MIT license.
+// Taken from Node 16.13.0
+// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually
+
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const net = require('net');
+const fp = '/blah/fadfa';
+const server = net.createServer(common.mustNotCall());
+server.listen(fp, common.mustNotCall());
+server.on('error', common.mustCall(function(e) {
+  assert.strictEqual(e.address, fp);
+}));