Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip npm integration test on Linux and Mac #1998

Merged
merged 1 commit into from
Mar 6, 2022
Merged

chore: skip npm integration test on Linux and Mac #1998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions node/integrationtest/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,31 @@ Deno.test("integration test of compat mode", {
const tempDir = await Deno.makeTempDir();
const opts = { env, cwd: tempDir };
const npmPath = join(tempDir, "node_modules", "npm");
const gulpPath = join(tempDir, "node_modules", "gulp");
const expressPath = join(tempDir, "node_modules", "express");
await t.step("yarn add npm", async () => {

await t.step("yarn add npm express", async () => {
await exec(`deno run --compat --unstable -A ${yarnUrl} add npm`, opts);
const stat = await Deno.lstat(join(npmPath, "package.json"));
assert(stat.isFile);
await exec(`deno run --compat --unstable -A ${yarnUrl} add express`, opts);
assert((await Deno.lstat(join(expressPath, "package.json"))).isFile);
});
await t.step("npm install express", async () => {
await exec(
`deno run --compat --unstable -A ${
join(npmPath, "index.js")
} install express`,
opts,
);
const stat = await Deno.lstat(join(expressPath, "package.json"));
assert(stat.isFile);
});

// FIXME(kt3k): npm in compat mode is broken in Linux and Mac
if (Deno.build.os === "windows") {
await t.step("npm install gulp", async () => {
await exec(
`deno run --compat --unstable -A ${
join(npmPath, "index.js")
} install gulp`,
opts,
);
const stat = await Deno.lstat(join(gulpPath, "package.json"));
assert(stat.isFile);
});
}

await t.step("run express example app", async () => {
await Deno.writeTextFile(
join(tempDir, "app.js"),
Expand All @@ -49,6 +58,7 @@ Deno.test("integration test of compat mode", {
);
await exec(`deno run --compat --unstable -A app.js`, opts);
});

await Deno.remove(tempDir, { recursive: true });
});

Expand Down