Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node/tls): basic support of tls.createServer #1948

Merged
merged 2 commits into from
Feb 23, 2022
Merged

feat(node/tls): basic support of tls.createServer #1948

merged 2 commits into from
Feb 23, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Feb 22, 2022 •
edited
Loading

This PR adds basic support of tls.createServer in std/node.

part of #1475

@kt3k kt3k requested a review from bartlomieju as a code owner February 22, 2022 15:07
@kt3k kt3k mentioned this pull request Feb 22, 2022
Closed
2 tasks
bartlomieju
bartlomieju approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 4f54453 into denoland:main Feb 23, 2022
@kt3k kt3k deleted the feat/tls-createServer branch February 23, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kt3k @bartlomieju