Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): add tls.connect #1923

Merged
merged 18 commits into from
Feb 16, 2022
Merged

feat(node): add tls.connect #1923

merged 18 commits into from
Feb 16, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Feb 15, 2022

This PR adds tls.connect in std/node.

part of #1475

@kt3k kt3k requested a review from bartlomieju as a code owner February 15, 2022 11:45
@kt3k kt3k mentioned this pull request Feb 15, 2022
Closed
bartlomieju
bartlomieju approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive! LGTM

@kt3k kt3k merged commit ed8671a into denoland:main Feb 16, 2022
@kt3k kt3k deleted the node_tls_alt branch February 16, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kt3k @bartlomieju @bnoordhuis