feat(node): add child_process.fork

.github/workflows/ci.yml

@@ -100,6 +100,8 @@ jobs:
 
       - name: Run Node tests canary
         run: deno test --unstable --allow-all --import-map=test_import_map.json --config strict-ts44.tsconfig.json node/_tools/test.ts
+        env:
+          DENO_NODE_COMPAT_URL: file:///${{ github.workspace }}/
 
   lint:
     runs-on: ubuntu-latest

node/_tools/config.json

@@ -20,6 +20,7 @@
       "test-buffer-from.js",
       "test-buffer-includes.js",
       "test-buffer-indexof.js",
+      "test-child-process-fork.js",
       "test-dns-lookup.js",
       "test-dns.js",
       "test-event-emitter-errors.js",
@@ -106,6 +107,7 @@
       "test-buffer-zero-fill-cli.js",
       "test-buffer-zero-fill-reset.js",
       "test-buffer-zero-fill.js",
+      "test-child-process-fork.js",
       "test-dns-lookup.js",
       "test-dns.js",
       "test-event-emitter-add-listeners.js",

node/_tools/suites/common/fixtures.js

@@ -0,0 +1,36 @@
+// Copyright 2018-2021 the Deno authors. All rights reserved. MIT license.
+// Copyright Joyent and Node contributors. All rights reserved. MIT license.
+
+'use strict';
+
+const path = require('path');
+const fs = require('fs');
+
+const fixturesDir = path.join(__dirname, '..', 'fixtures');
+
+function fixturesPath(...args) {
+  return path.join(fixturesDir, ...args);
+}
+
+function readFixtureSync(args, enc) {
+  if (Array.isArray(args))
+    return fs.readFileSync(fixturesPath(...args), enc);
+  return fs.readFileSync(fixturesPath(args), enc);
+}
+
+function readFixtureKey(name, enc) {
+  return fs.readFileSync(fixturesPath('keys', name), enc);
+}
+
+function readFixtureKeys(enc, ...names) {
+  return names.map((name) => readFixtureKey(name, enc));
+}
+
+module.exports = {
+  fixturesDir,
+  path: fixturesPath,
+  readSync: readFixtureSync,
+  readKey: readFixtureKey,
+  readKeys: readFixtureKeys,
+};
+

node/_tools/suites/fixtures/child-process-spawn-node.js

@@ -0,0 +1,14 @@
+const assert = require('assert');
+// TODO(kt3k): Uncomment this when util.debuglog is added
+// const debug = require('util').debuglog('test');
+const debug = console.log;
+
+function onmessage(m) {
+  debug('CHILD got message:', m);
+  assert.ok(m.hello);
+  process.removeListener('message', onmessage);
+}
+
+process.on('message', onmessage);
+// TODO(kt3k): Uncomment the below when the ipc features are ready
+// process.send({ foo: 'bar' });

node/_tools/suites/parallel/test-child-process-fork.js

@@ -0,0 +1,72 @@
+// deno-fmt-ignore-file
+// deno-lint-ignore-file
+
+// Copyright Joyent and Node contributors. All rights reserved. MIT license.
+// Taken from Node 16.13.0
+// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually
+
+// Copyright Joyent, Inc. and other Node contributors.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the
+// "Software"), to deal in the Software without restriction, including
+// without limitation the rights to use, copy, modify, merge, publish,
+// distribute, sublicense, and/or sell copies of the Software, and to permit
+// persons to whom the Software is furnished to do so, subject to the
+// following conditions:
+//
+// The above copyright notice and this permission notice shall be included
+// in all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+// USE OR OTHER DEALINGS IN THE SOFTWARE.
+// Flags: --no-warnings
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const { fork } = require('child_process');
+const args = ['foo', 'bar'];
+const fixtures = require('../common/fixtures');
+const debug = require('util').debuglog('test');
+
+const n = fork(fixtures.path('child-process-spawn-node.js'), args);
+
+assert.strictEqual(n.channel, n._channel);
+assert.deepStrictEqual(args, ['foo', 'bar']);
+
+n.on('message', (m) => {
+  debug('PARENT got message:', m);
+  assert.ok(m.foo);
+});
+
+// https://github.com/joyent/node/issues/2355 - JSON.stringify(undefined)
+// returns "undefined" but JSON.parse() cannot parse that...
+/* TODO(kt3k): Uncomment the below test cases when the ipc features are ready.
+assert.throws(() => n.send(undefined), {
+  name: 'TypeError',
+  message: 'The "message" argument must be specified',
+  code: 'ERR_MISSING_ARGS'
+});
+assert.throws(() => n.send(), {
+  name: 'TypeError',
+  message: 'The "message" argument must be specified',
+  code: 'ERR_MISSING_ARGS'
+});
+
+assert.throws(() => n.send(Symbol()), {
+  name: 'TypeError',
+  message: 'The "message" argument must be one of type string,' +
+           ' object, number, or boolean. Received type symbol (Symbol())',
+  code: 'ERR_INVALID_ARG_TYPE'
+});
+n.send({ hello: 'world' });
+*/
+
+n.on('exit', common.mustCall((c) => {
+  assert.strictEqual(c, 0);
+}));

node/_tools/suites/parallel/test-url-parse-format.js

@@ -8,9 +8,8 @@
 'use strict';
 const common = require('../common');
 
-// TODO(getspooky): Implement `hasIntl`, `skip`
-// if (!common.hasIntl)
-//   common.skip('missing Intl');
+if (!common.hasIntl)
+  common.skip('missing Intl');
 
 const assert = require('assert');
 const inspect = require('util').inspect;
@@ -982,9 +981,8 @@ for (const u in parseTests) {
   expected = parseTests[u].href;
   actual = url.format(parseTests[u]);
 
-  // assert.strictEqual(actual, expected,
-  //   `format(${u}) == ${u}\nactual:${actual}`);
-
+  assert.strictEqual(actual, expected,
+                     `format(${u}) == ${u}\nactual:${actual}`);
 }
 
 {