Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix reference error in node ci #1694

Merged
merged 4 commits into from
Dec 9, 2021
Merged

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Dec 9, 2021

Now the CI is blocked by the reference error in node/internal_binding/_node.ts (cf: https://github.com/denoland/deno_std/runs/4466763309?check_suite_focus=true ), which is probably caused by denoland/deno#13025

The issue seems only happening with swc. This PR works around it by using tsc for transpiling the problematic enum

This PR works around the issue by avoiding using enum reference in enum definition.

reference: transpiled result in playground https://www.typescriptlang.org/play?ssl=11&ssc=1&pln=11&pc=4#code/KYDwDg9gTgLgBMAdgVwLZwKKIMYQCYCWiA5gM5wDec1AUNQIIDKAwgJKsA0cA9N3AAzU4dOAFUAKgDEAHF15wAjEJEAhJhgBsAFjl8ATMuqjmjPbrgBmQ3BWsAcvQBKATXNbrACQwANcwFZrFVFJSQxHcw1A9W1RRwAZcwB2azj6cXslAF44d3l3bNsHFw4aAF9qIA

@kt3k kt3k merged commit 7cce16f into denoland:main Dec 9, 2021
@kt3k kt3k deleted the ci/fix-ref-error branch December 9, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants