feat(node): Add missing url.parse

[getspooky]

Ref #1666

[kt3k]

I think url.parse should return url.Url object, not a global URL object

You can check it in Node.js repl like the below

> url.parse("https://example.com") instanceof url.Url
true
> url.parse("https://example.com") instanceof URL
false

[kt3k]

You forgot returning self?

[kt3k]

@getspooky
Can you also enable some of native node.js test cases? The instruction for doing it is available in node/README.md

[getspooky]

@kt3k fixed , Now parse return url.Url object, not a global URL object.

Deno:

test [url] URL ...Url {
  protocol: "http:",
  slashes: true,
  auth: null,
  host: "github.com",
  port: null,
  hostname: "github.com",
  hash: null,
  search: null,
  query: null,
  pathname: "/",
  path: "/",
  href: "http://github.com/"
}

Node:

> url.parse("http://github.com")
Url {
  protocol: 'http:',
  slashes: true,
  auth: null,
  host: 'github.com',
  port: null,
  hostname: 'github.com',
  hash: null,
  search: null,
  query: null,
  pathname: '/',
  path: '/',
  href: 'http://github.com/'
}

[kt3k]

@getspooky

fixed , Now parse return url.Url object, not a global URL object.

Thanks for updating! The change looks good to me, but the test file test-url-parse-format.js is not added to the source tree. Please remove test-url-parse-format.js from ignore part of node/_tools/config.json first, then run node/_tools/setup.ts, which should copy the actual test file under node/_tools/suites/

[getspooky]

@kt3k done

[wafuwafu13]

@getspooky

https://github.com/denoland/deno_std/runs/4410914506?check_suite_focus=true

AssertionError: Failed assertion: error: Uncaught TypeError: common.skip is not a function

We haven't implemented hasIntl yet, so it would be nice to comment it out like this.

[kt3k]

test-url-parse-format.js is not passing in mac and ubuntu (See the CI logs

The assertion at line 985 seems failing. Maybe let's comment out it as well with a TODO comment.

Also now you modified test-url-parse-format.js. So now you need to add test-url-parse-format.js to ignore part of config.json

[getspooky]

@kt3k fixed

[kt3k]

@getspooky LGTM. Thank you for your contribution!

url.format tests are still remaining, but this adds very accurate compatibility of url.parse. Nice work!