Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc (collections): Add contribtution guide, some principles and extend README #1110

Merged
merged 6 commits into from
Aug 10, 2021

Conversation

LionC
Copy link
Contributor

@LionC LionC commented Aug 7, 2021

This adds a contribution guide with a checklist for common things I have been seeing in recent PRs to the module. It also
adds a small philosophy section that tries to summarize the current ideas behind the module and which might answer common
questions.

It also adds a bit of info to the README and updates missing functions.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LionC Thank you for the contribution. Left one comment. Also this needs formatting by deno fmt

collections/CONTRIBUTING.md Outdated Show resolved Hide resolved
@LionC
Copy link
Contributor Author

LionC commented Aug 9, 2021

Done @kt3k

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LionC LGTM. Thanks! Nice work!

@kt3k kt3k merged commit 252fd1a into denoland:main Aug 10, 2021
@LionC LionC deleted the contributing-guide branch August 10, 2021 12:25
@LionC LionC restored the contributing-guide branch August 21, 2021 16:10
@LionC LionC deleted the contributing-guide branch August 23, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants