Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fs/promises full implementation #1083

Merged
merged 6 commits into from
Aug 1, 2021
Merged

feat: fs/promises full implementation #1083

merged 6 commits into from
Aug 1, 2021

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Aug 1, 2021 •
edited
Loading

This adds a full implementation for fs/promises.

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@guybedford
Copy link
Contributor Author

Ahh of course there's already a partial promises/mod.ts but that seems like a lot of work... Let me know if you want to still proceed with this approach or not. Separate files seems like overkill to me personally though.

@guybedford guybedford mentioned this pull request Aug 1, 2021
Merged
@guybedford
Copy link
Contributor Author

I've updated this PR to instead replace the previous promises implementation.

@guybedford guybedford changed the title feat: fs_promises base implementation feat: fs/promises full implementation Aug 1, 2021
This was referenced Aug 1, 2021
Merged
Merged
bartlomieju
bartlomieju approved these changes Aug 1, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit d130ef6 into denoland:main Aug 1, 2021
@guybedford guybedford deleted the fs-promises branch August 1, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guybedford @CLAassistant @bartlomieju