-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lookPath
function to find the path of an executable
#1056
Comments
Port of the [lookPath][1] function from Go's exec package. Fixes denoland#1056. [1]https://pkg.go.dev/os/exec#example-LookPath
Port of the [lookPath][1] function from Go's exec package. Fixes denoland#1056. [1]https://pkg.go.dev/os/exec#example-LookPath
If anyone wants to pick up where I left off, all that was left on my branch was to add tests for windows and validate that it works there, I doubt that it wouldn't. I no longer have the time (or even a Windows machine) to carry on this issue. |
I'd love to pick this up, but is this desirable @cjihrig? |
It looks like there was no opposition to #1057, so I'm OK with it. cc: @kt3k @bartlomieju in case the sentiment has changed in the past year. |
I'm still in favor. |
We're still in favour of having this. Would anyone like to pick this up? |
I'll do it eventually, I have everything working in a branch of mine already I just need to write some tests. |
Would you be able to submit a draft PR just so we can start looking at and thinking about implementation? |
Yeah I'll probably get it to by thursday night. Pretty busy this week. |
Golang's exec package has this neat
LookPath
function that allows finding the absolute path to an executable by it's shortname that I think would be useful in the Deno standard lib. Here's an example usage in Go:Since we don't have an
exec
package, I propose we put this function in thefs
package, thoughpath
would also be a good choice.The text was updated successfully, but these errors were encountered: