Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Function::get/set_name() #792

Merged
merged 7 commits into from
Oct 1, 2021
Merged

feat: Function::get/set_name() #792

merged 7 commits into from
Oct 1, 2021

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Oct 1, 2021

Add bindings for v8::Function::GetName() and v8::Function::SetName()

AaronO added 3 commits October 1, 2021 14:32
Add bindings for v8::Function::GetName() and v8::Function::SetName()
@AaronO AaronO requested a review from bnoordhuis October 1, 2021 13:07
AaronO added a commit to AaronO/deno that referenced this pull request Oct 1, 2021
Makes native builtin functions easier to recognize when debugging/profiling, they would otherwise appear as "(anonymous)" functions

Requires denoland/rusty_v8#792
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test

@AaronO AaronO requested a review from ry October 1, 2021 18:31
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronO AaronO merged commit 6ccf15c into main Oct 1, 2021
@AaronO AaronO deleted the feat/function-get-set-name branch October 1, 2021 20:38
AaronO added a commit to AaronO/deno that referenced this pull request Oct 5, 2021
Makes native builtin functions easier to recognize when debugging/profiling, they would otherwise appear as "(anonymous)" functions

Requires denoland/rusty_v8#792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants