Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add ICU support in embedded v8. #382

Closed
wants to merge 2 commits into from

Conversation

kishiguro
Copy link
Contributor

@kishiguro kishiguro commented May 26, 2020

This is PR for denoland/deno#1968 Add ICU support in embedded v8. Please note this PR is still work in progress. Following changes are made in this PR.

  • Add submodule third_part/icu@ f222396
  • Set v8_enable_i18n_support = true in .gn for ICU support.

We need have following change to submodule icu.

  • Set icu_use_data_file = false in third_party/icu/config.gni
  • (Mac build fix) third_party/icu/config/mac/BUILD.gn b/config/mac/BUILD.gn
  • (Windows build fix) third_party/icu/scripts/make_data_assembly.py

Would you mind to suggest how I should modify submodule code with current build ecosystem? Apply patch from build.rs or fork the original repository and apply the patch to it?

@CLAassistant
Copy link

CLAassistant commented May 26, 2020

CLA assistant check
All committers have signed the CLA.

@piscisaureus
Copy link
Member

We'll have to find a solution to make the crate stay under 10 MB (the limit imposed by crates.io).
ICU data might have to live in a separate crate or get downloaded through some other means.

@kishiguro
Copy link
Contributor Author

I see. Maybe it is better to download each platform's *.{o, obj} file which has ICU data.

@kishiguro
Copy link
Contributor Author

I've made updated PR at #390. So let me close this ticket.

@kishiguro kishiguro closed this May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants