[proposal] feat: Custom Stylesheet injection #476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this issue solved by using _app.tsx in conjunction with Head component? Injecting style sheets here seems to work nicely, or am I missing something? Usage example taken from tests: /** @jsx h */
/** @jsxFrag Fragment */
import { Fragment, h } from "preact";
import { Head } from "$fresh/runtime.ts";
import { AppProps } from "$fresh/server.ts";
export default function App(props: AppProps) {
return (
<>
<Head>
<meta name="description" content="Hello world!" />
</Head>
<props.Component />
</>
);
} |
That is actually true! I haven't found it anywhere (I might have missed it in documentation) and it seems the others missed it as well. Thanks a lot for input, I will close this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there were multiple requests like #371 to have ability to include custom stylesheets into
headelement of root html. I don't think we need full ability to override whole root template (like #380), but have ability to inject stylesheets would suffices.With this approach we could only modify render function in
main.tsto have stylesheets included on every page.Example:
I will leave the decision for this feature to you, but it would be enough for my needs to have this change rather than overriding whole root template.