feat: add transform for import.meta.resolve/main expressions
#322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsherret The CI test fail, need help |
|
for now (node 20.4.0) |
Gaubee
changed the title
import.meta.resolve/main expressions
dsherret
reviewed
Jul 19, 2023
lib/compiler_transforms.ts
Outdated
| } | ||
| } | ||
| if (originNode !== undefined) { | ||
| node = originNode; |
There was a problem hiding this comment.
This PR looks very good other than this state being maintained like this, which is a bit confusing. I'm going to push a change.
dsherret
approved these changes
Jul 19, 2023
dsherret
changed the title
import.meta.resolve/main expressionsimport.meta.resolve/main expressions
waterbang
added a commit
to BioforestChain/dweb_browser
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import.meta.resolve now work in commonjs and esmodule
import.meta.main now work in esmodule too