feat: terse lockfile #26
Conversation
|
This PR seems to implement lockfile version 4 proposed in denoland/deno#23213. I want to experiment with some changes to the lockfile format to make it possible to build reproducible vendored dependencies from the lockfile only. I think it would be easier for me, if we can get this PR merged, so I can work from there. What is the state of this PR / are there still some features missing? |
It's basically good to go, but I need to get a final thumbs up from the team about the changes. I was busy working on workspaces the past month, but I'm planning to get this one merged within the next couple of weeks (and when it lands, it will only be behind the It seems that #30 is mostly refactoring changes? It might be better to land those separately. |
|
Nice to hear that lockfile v4 is actually on the roadmap. #30 is a mostly fixing up and finishig this PR. I think at 8ab3681 most of the problems in this PR are fixed and I switched to refactoring. If you want to I can try to split it up into one PR for fixes and one for refactoring. How does DENO_FUTURE work? I assume that the expected behaviour is that it is backwards-compatible with old lockfile versions. However while #30 is able to read all lockfiles versions when writing modified lockfiles it will always output v4 lockfiles. I am planning to add back the functionality to write v3 lockfiles in the coming days, based on your high performance v4 printer and not on serde. |
I wouldn't recommend working on that as outputting v3 lockfiles will be removed once this is stabilized. |
| Value::String(v) => Some(v), | ||
| _ => None, | ||
| }) | ||
| .unwrap_or_else(|| "3".to_string()), |
There was a problem hiding this comment.
Is this on purpose to default to version 3 instead of 4?
There was a problem hiding this comment.
Yes. This is only on with DENO_FUTURE for now
| output.push_str(" \""); | ||
| output.push_str(key); | ||
| output.push_str("\": {\n"); | ||
| output.push_str(" \"integrity\": \""); | ||
| output.push_str(&value.integrity); | ||
| output.push('"'); |
There was a problem hiding this comment.
Is it really better to hand write JSON in this file?
There was a problem hiding this comment.
Not sure. I wanted to avoid clones and haven't meadured the performance of this yet. I'm going to rewrite this once dropping v3 I think.
Closes #19