fix: resolve jsxImportSource with types mode in absence of jsxImportSourceTypes #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Aug 18, 2024
|
It looks like the lockfile changes occurred due to denoland/deno#25059 -- I'm looking into why |
|
Confirmed that denoland/deno_lockfile#34 fixes the issue. I will land this in Deno and then we can merge this PR. |
|
@dsherret Thanks, it's green now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a
jsxImportSourceand nojsxImportSourceTypes, we need to try and resolve the same specifier withResolutionMode::Typesto see if it resolves somewhere else, as we do with ES deps.I hit this bug in the LSP specifically when using jsx import source
npm:preactwith byonm.