fix(fast_check): should not surface errors for external modules #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Apr 1, 2024
There was a problem hiding this comment.
It's very hard to test this, so the tests are in denoland/deno#23173
bartlomieju
approved these changes
Apr 2, 2024
dsherret
added a commit
to denoland/deno
that referenced
this pull request
Apr 11, 2024
Had to revert back swc due to swc-project/swc#8840 Fixes: - denoland/deno_lint#1262 - denoland/deno_doc#538 - denoland/deno_doc#537 - denoland/deno_graph#430 - denoland/deno_graph#425 - denoland/deno_graph#432
bartlomieju
pushed a commit
to denoland/deno
that referenced
this pull request
Apr 12, 2024
Had to revert back swc due to swc-project/swc#8840 Fixes: - denoland/deno_lint#1262 - denoland/deno_doc#538 - denoland/deno_doc#537 - denoland/deno_graph#430 - denoland/deno_graph#425 - denoland/deno_graph#432
littledivy
pushed a commit
to littledivy/deno
that referenced
this pull request
Apr 19, 2024
Had to revert back swc due to swc-project/swc#8840 Fixes: - denoland/deno_lint#1262 - denoland/deno_doc#538 - denoland/deno_doc#537 - denoland/deno_graph#430 - denoland/deno_graph#425 - denoland/deno_graph#432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They shouldn't be surfaced because with byonm, modules in the node_modules directory are external.
Part of jsr-io/jsr#323